omedusyo/minisql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove TODO's about Null. We'll implement Option<T> in another PR

Browse source
This commit is contained in:
Yuriy Dupyn 2024-02-01 13:25:09 +01:00
parent ee757c7ca2
commit 8cc5b92808
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
minisql/src/type_system.rs
View file

@ -13,9 +13,6 @@ pub enum DbType {
// ==============Values================ // ==============Values================
pub type Uuid = u64; pub type Uuid = u64;
// TODO: What about nulls? I would rather not have that in SQL, it sucks.
// I would rather have non-nullable values by default,
// and something like an explicit Option type for nulls.
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)] #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
pub enum Value { pub enum Value {
Number(f64), // TODO: Can't put floats as keys in maps, since they don't implement Eq. What to Number(f64), // TODO: Can't put floats as keys in maps, since they don't implement Eq. What to
@ -28,7 +25,6 @@ pub enum IndexableValue {
String(String), String(String),
Int(u64), Int(u64),
Uuid(Uuid), Uuid(Uuid),
// TODO: what about null?
} }
impl DbType { impl DbType {