From 8cc5b9280813581f15a51b524c484c70bbe51aa2 Mon Sep 17 00:00:00 2001 From: Yuriy Dupyn <2153100+omedusyo@users.noreply.github.com> Date: Thu, 1 Feb 2024 13:25:09 +0100 Subject: [PATCH] Remove TODO's about Null. We'll implement Option in another PR --- minisql/src/type_system.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/minisql/src/type_system.rs b/minisql/src/type_system.rs index abae701..532025f 100644 --- a/minisql/src/type_system.rs +++ b/minisql/src/type_system.rs @@ -13,9 +13,6 @@ pub enum DbType { // ==============Values================ pub type Uuid = u64; -// TODO: What about nulls? I would rather not have that in SQL, it sucks. -// I would rather have non-nullable values by default, -// and something like an explicit Option type for nulls. #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)] pub enum Value { Number(f64), // TODO: Can't put floats as keys in maps, since they don't implement Eq. What to @@ -28,7 +25,6 @@ pub enum IndexableValue { String(String), Int(u64), Uuid(Uuid), - // TODO: what about null? } impl DbType {