omedusyo/minisql
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Explain why implementing Debug for Response::Selected(...) is problematic

Browse source
This commit is contained in:
Yuriy Dupyn 2024-02-01 13:29:05 +01:00
parent df108f581c
commit 83fd46b4f5
1 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
minisql/src/interpreter.rs
View file

@ -35,10 +35,9 @@ impl std::fmt::Debug for Response<'_> {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> {
use Response::*;
match self {
Selected(_schema, _columns, _rows) =>
// TODO: How can we iterate through the rows without having to take ownership of
// them?
{
Selected(_schema, _columns, _rows) => {
// It seems that Rust requires ownership of rows to format them here.
// This is why we output the string below
f.write_str("Some rows... trust me")
}
Inserted => f.write_str("Inserted"),